New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Pro-only files from Lite version #285

Closed
raamdev opened this Issue Jun 19, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@raamdev
Contributor

raamdev commented Jun 19, 2016

As of v160618, the Lite release built by Phing includes several Pro-only files:

src/includes/classes/UtilsRve.php
src/vendor/lusitanian/
src/vendor/mailchimp/

And possibly some others.

We need to do a more thorough review than what was done in #237 and make sure that we have stripped any dependencies from the Lite codebase (i.e., placed the appropriate Pro-only markers in the codebase). A full round of tests of the Lite version will then need to be conducted while watching the error log.

@raamdev raamdev added the todo label Jun 19, 2016

@raamdev raamdev added this to the Next Release milestone Jun 19, 2016

@raamdev raamdev self-assigned this Jul 19, 2016

raamdev added a commit to websharks/comment-mail-pro that referenced this issue Aug 5, 2016

raamdev added a commit to websharks/comment-mail-pro that referenced this issue Aug 5, 2016

@raamdev raamdev referenced this issue Aug 5, 2016

Closed

Feature/285 #81

@raamdev

This comment has been minimized.

Contributor

raamdev commented Aug 5, 2016

Next Release Changelog:

  • Removed several development-only files from the distributable that were inadverantly included during the build process. See Issue #285.

@raamdev raamdev closed this Aug 5, 2016

raamdev added a commit that referenced this issue Aug 18, 2016

Phing release of v160818 with the following changes:
- **Bug Fix**: Fixed a bug where the "My Comment Subscriptions" link would appear on the Add New Subscription page (when Subscribing without Commenting) and would lead to a page that displayed an error message stating that there were no subscriptions to list. That link is now hidden when there are no subscriptions to list. Props @Reedyseth @kristineds. See [Issue #229](#229).
- **Bug Fix** (Pro): Removed an erroneous anchor tag in the Advanced Template for Comment Notification Message Body. Props @kristineds. See [Issue #287](#287).
- **UI Enhancement:** Improved the nav bar at the top of the options pages to reduce unnecessary whitespace. Also moved the Restore button to the nav bar so that it's not so prominent. Props @renzms. See [Issue #284](#284).
- **UI Enhancement:** Added links to the Comment Mail [Twitter](http://twitter.com/CommentMail) and [Facebook](https://www.facebook.com/Comment-Mail-565683256946855/) pages to the nav bar on the options page. Props @renzms. See [Issue #286](#286).
- **UX Enhancement:** Removed IP address information from email notification templates to better comply with data protection laws in certain countries. Props @kristineds. See [Issue #288](#288).
- **SEO Improvement:** Added `rel="nofollow"` to the "Subscribe without Commenting" link and "Manage Subscriptions" link on the comment subscription form to avoid indexing or transferring PageRank. Props @IvanRF. See [Issue #80](websharks/comment-mail-pro#80).
- Removed several development-only files from the distributable that were inadvertently included during the build process. See [Issue #285](#285).
- Added Renz Sevilla (`renzms`) to the contributors list.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Aug 18, 2016

Comment Mail v160818 has been released and includes changes from this GitHub Issue. See the v160818 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#285).

@websharks websharks locked and limited conversation to collaborators Aug 18, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.