New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe without commenting shows unapproved comments #299

Closed
IvanRF opened this Issue Sep 15, 2016 · 14 comments

Comments

Projects
None yet
4 participants
@IvanRF

IvanRF commented Sep 15, 2016

I just saw something weird in my Subscriptions list and found this bug: Comments that were not yet approved are shown in the subscribe without commenting page (Add New Subscription).

I had a user subscribed to a comment that I did not approved 😄

@raamdev

This comment has been minimized.

Contributor

raamdev commented Sep 16, 2016

@IvanRF Thanks for the report! We'll get this tested soon.

@raamdev raamdev added this to the Next Release milestone Sep 16, 2016

@renzms renzms self-assigned this Sep 30, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented Sep 30, 2016

@raamdev

Tested this under the following conditions:

  • WordPress 4.6.1 running Twenty Sixteen theme with Comment Mail Pro Version 160818 / Comment Mail Version 160824 installed
  • Dashboard → Settings → Discussion → Check Comment must be manually approved
  • Logged in/registered user and unregistered user comments

When commenting on a post as either a registered/unregistered user, the comment will appear to the user as an unapproved comment awaiting moderation after submission of the comment.

Hitting reply to the unapproved comment will allow the same user to Subscribe without commenting to the comment.

screen shot 2016-09-30 at 1 19 05 pm

They will then be taken to the Add a new subscription page, where they can view all comments, including the unapproved comments.

screen shot 2016-09-30 at 1 19 48 pm

@IvanRF

This comment has been minimized.

IvanRF commented Sep 30, 2016

Also, without hitting Reply if another user enters the page and just selects Subscribe without commenting, he will see the unapproved comment too.

@renzms

This comment has been minimized.

Contributor

renzms commented Oct 2, 2016

Also, without hitting Reply if another user enters the page and just selects Subscribe without commenting, he will see the unapproved comment too.

@raamdev

I can confirm this as well, subscribing without commenting allows anyone to view the whole comments list including unapproved comments.

@raamdev raamdev removed the needs testing label Oct 3, 2016

@raamdev raamdev assigned jaswrks and unassigned renzms Oct 3, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 3, 2016

@renzms Thanks for testing! That confirms this is a bug that needs to be fixed.


@jaswsinc Bug is as follows: Unapproved comments should not appear in the list of comments to subscribe to when subscribing without commenting.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Oct 6, 2016

Copy that. Referencing this block. Estimate 1 day.

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 2, 2016

jaswsinc
**Bug Fix:** Exclude unapproved comments from the dropdown menu on th…
…e "Subscribe Without Commenting" form. See also: [issue #299](websharks/comment-mail#299) for further details.

@jaswrks jaswrks referenced this issue Nov 2, 2016

Merged

PR: feature/299 #88

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 2, 2016

Next Release Changelog:

  • Bug Fix: Exclude unapproved comments from the dropdown menu on the 'Subscribe Without Commenting' form. See also: issue #299 for further details.

@jaswrks jaswrks closed this Nov 2, 2016

@jaswrks jaswrks reopened this Nov 2, 2016

@raamdev raamdev assigned renzms and unassigned jaswrks Nov 3, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 3, 2016

@renzms Could you please test a dev build to confirm that this issue has been resolved?

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 4, 2016

@raamdev / @jaswsinc

Hi Guys!

I can confirm that unapproved comments no longer appear in the Subscriptions list! 👍

screen shot 2016-11-04 at 8 11 45 pm


However...

I have observed a new minor issue with the Comment list field on the Subscriptions page.

Expected Behavior:

  • On posts that have an already approved Comment, the field appears with a dropdown menu.

screen shot 2016-11-04 at 8 11 38 pm

Observed Behavior:

  • On posts that have no comments at all, the field appears to have arrows for entering numerical values.

screen shot 2016-11-04 at 8 11 27 pm

screen shot 2016-11-04 at 8 14 35 pm

  • The field also seems to accept manual numerical input

screen shot 2016-11-04 at 8 14 46 pm

@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 9, 2016

@jaswsinc See above. ↑ Can we just show a message in place of the select box that says "This post has no comments." when there are no comments for the selected post?

@raamdev raamdev assigned jaswrks and unassigned renzms Nov 9, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 9, 2016

Yes, that sounds like a good idea to me also. Please fork that into a new issue.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 9, 2016

Please fork that into a new issue.

Done. I don't think that issue warrants holding up the Comment Mail RC, so I'll leave that work for a future release milestone.

@raamdev raamdev removed the ready for work label Nov 9, 2016

@raamdev raamdev assigned renzms and unassigned jaswrks Nov 10, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@raamdev

Other than the issue here about the numerical values: #310

Tested to make sure it doesn't show unapproved comments and it's working! 👍

raamdev added a commit that referenced this issue Nov 18, 2016

Phing release of v161118 with the following changes:
- **Bug Fix:** Exclude unapproved comments from the dropdown menu on the 'Subscribe Without Commenting' form. See [Issue #299](#299).
- **Enhancement:** When parsing templates, this release uses `include()` instead of `eval()` whenever possible. This improves compatibility with shared hosting providers and makes it easier to debug template parsing issues should they occur. See [Issue #192](#192).
- **PHP v7 Compatibility:** After further testing, it was found that while Comment Mail is compatible with PHP v7.0, you must be running PHP v7.0.9+. Starting with this release of Comment Mail if you're running PHP v7 < 7.0.9 a warning is displayed in the WordPress Dashboard asking the site owner to upgrade to PHP v7.0.9 or higher. Note: While PHP v7.0.9 is adequate, PHP v7.0.10 is strongly recommended. See [Issue #272](#272).
- **New SparkPost Integration** (Pro):  It is now possible to use SparkPost for Replies-via-Email (RVE) instead of Mandrill. Note that SparkPost is now the suggested RVE Handler for Comment Mail because Mandrill changed its pricing structure a while back. In short, Mandrill requires a fee, whereas SparkPost (recommended) offers Relay Webhooks as a part of their free plan. See [Issue #265](#265).
- **New Feature** (Pro): Adding support for MailChimp integration. It is now possible to give users the option of subscribing to your site-wide mailing list whenever they leave a comment or reply; i.e., in addition to subscribing to comment reply notifications they can also join your MailChimp mailing list. See [Issue #114](#114).
@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 18, 2016

Comment Mail v161118 has been released and includes changes from this GitHub Issue. See the v161118 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#299).

@raamdev raamdev closed this Nov 18, 2016

@websharks websharks locked and limited conversation to collaborators Nov 18, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.