New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StCR conflict detection no longer working #315

Closed
raamdev opened this Issue Nov 11, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Nov 11, 2016

The conflict detection for Subscribe to Comments Reloaded is no longer working. When both StCR and Comment Mail are active, there is no Dashboard notice indicating that both plugins should not be enabled at the same time.

Steps to reproduce

  • Install Comment Mail >= v161110-RC and StCR v160915+
  • Activate and enable both plugins

Observed Behavior

No Dashboard messages appear.

Expected Behavior

A Dashboard notice should warn me that StCR and Comment Mail should not be enabled at the same time.

@raamdev raamdev added this to the Future Release milestone Nov 11, 2016

@raamdev raamdev removed the needs estimate label Nov 29, 2016

@raamdev raamdev removed the needs estimate label Nov 29, 2016

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 2, 2016

jaswsinc
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded…
…' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](websharks/comment-mail#315).

@jaswrks jaswrks referenced this issue Dec 2, 2016

Merged

PR: feature/315 #95

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 2, 2016

Next Release Changelog:

  • Bug Fix: The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See Issue #315.
@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 2, 2016

Noting that this particular conflict detection never existed prior. However, it is now.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 2, 2016

Noting that this particular conflict detection never existed prior. However, it is now.

Hmm, that's very odd. I'm almost certain I remember seeing a Comment Mail message telling me that StCR and Comment Mail shouldn't be active at the same time... maybe I imagined it!

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 3, 2016

You might be right. If it was, I just don't remember it. Whenever I reviewed the codebase this time around it was not in there at all. That's what I should have said; i.e., I didn't fix anything. I had to add this in because it wasn't there at all.

@renzms

This comment has been minimized.

Contributor

renzms commented Dec 13, 2016

@jaswsinc @raamdev

Confirmed Working

Prompt appears and does not activate Comment Mail if StCR is present.

screen shot 2016-12-13 at 3 55 32 pm

raamdev added a commit that referenced this issue Dec 13, 2016

Phing release of v161213 with the following changes:
- **Bug Fix:** Prevent browser autocomplete in Comment Mail options. See [Issue #319](#319).
- **Bug Fix:** Searching by email address alone should always narrow to the search to that specific email address and not result in any fuzzy or fulltext matching. See [Issue #226](#226).
- **Bug Fix:** The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See [Issue #315](#315).
- **Bug Fix:** Notify 'Subscribe to Comments Reloaded' users about the comment form template being disabled under certain scenarios. See [Issue #314](#314).
- **Bug Fix:** Do not attempt to import 'Subscribe to Comments Reloaded' (StCR) settings if StCR is no longer installed, even if old StCR options exist in the database. See [Issue #294](#294).
- **Bug Fix** (Pro): Do not show SparkPost partner image when Mandrill is selected as the RVE handler. See [Issue #318](#318).
- **Bug Fix** (Pro): Conflict checks between lite and pro corrected. This was not working properly in the previous release; i.e., installing Comment Mail Pro when Comment Mail Lite is already running should result in Comment Mail Lite being deactivated automatically. See [Issue #270](#270).
- **New Feature:** It is now possible to manually process the outgoing mail queue. See: **WP Dashboard → Comment Mail → Mail Queue**. See also [Issue #282](#282).
- **New Feature** (Pro): In Comment Mail Pro it is now possible to enable/disable comment content clipping entirely; e.g., if you prefer that email notifications include the full original comment content in raw HTML instead of being clipped and displayed in the email as plain text. See: **WP Dashboard → Comment Mail → Config. Options → Email Notification Clips**. See also: [Issue #281](#281).
- **Accessibility:** This release improves screen reader accessibility by adding `aria-hidden="true"` to all FontAwesome icons. See [Issue #304](#304).
- **Accessibility:** This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: **Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings**. See also [Issue #304](#304).
@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 13, 2016

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#315).

@raamdev raamdev closed this Dec 13, 2016

@websharks websharks locked and limited conversation to collaborators Dec 13, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.