New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html validation Error Bad value for attribute action on form #1006

Closed
AJDesigns opened this Issue Oct 26, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@AJDesigns

AJDesigns commented Oct 26, 2016

EXPLANATION OF THE ISSUE

Version 160801 + s2Member Pro v160801

The [s2Member-List ] Shortcode with search attribute turned on creates invalid html: (EMPTY form action)

Here is the top of the form output when using the search members attribute with a member list shortcode:

## STEPS TO REPRODUCE THE ISSUE

Create a member list with search enabled and check the form action field with an HTML validator

This code is not adding an action to the form:

" method="get" autocomplete="off"> ## BEHAVIOR THAT I EXPECTED

Valid HTML

BEHAVIOR THAT I OBSERVED

@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 27, 2016

@AJDesigns Thanks for the report.

Noting that the HTML5 spec doesn't appear to explicitly require an action attribute:

The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces. [emphasis added]


@jaswsinc Is this expected behavior?

2016-10-27_17-20-19

@AJDesigns

This comment has been minimized.

AJDesigns commented Oct 28, 2016

I think in HTML 4 specifying the action is not required so the following is valid:

<form action="" method="get" autocomplete="off">

But in HTML 4 this is not valid:

<form method="get" autocomplete="off">

I believe the opposite is true in HTML5

In HTML5 the following is valid:
`

`

But the next two are not valid:


<form action=""  method="get" autocomplete="off"> 
<form action  method="get" autocomplete="off"> 
@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 22, 2016

@jaswsinc Still awaiting your feedback here.

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Nov 22, 2016

jaswrks pushed a commit that referenced this issue Nov 22, 2016

jaswsinc
@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 22, 2016

Yes, that's a bug.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 22, 2016

Next Release Changelog:

  • (s2Member Pro) Bug Fix: In the [s2Member-List /] search box shortcode an empty action="" attribute produces a warning due to invalid syntax in HTML v5. Fixed in this release. See Issue #1006

@raamdev raamdev added this to the Future Release milestone Nov 22, 2016

@raamdev raamdev added bug and removed needs feedback labels Nov 22, 2016

@raamdev raamdev modified the milestones: Next Release, Future Release Nov 22, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 29, 2016

s2Member v161129 has been released and includes changes from this GitHub Issue. See the v161129 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1006).

@raamdev raamdev closed this Nov 29, 2016

@websharks websharks locked and limited conversation to collaborators Nov 29, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.