New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2Member interferes with Comet Cache Pro Dashboard message #1034

Closed
raamdev opened this Issue Dec 23, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@raamdev
Contributor

raamdev commented Dec 23, 2016

s2Member interferes with the style of the Dashboard message generated by Comet Cache Pro:

2016-12-23_17-53-55

@raamdev raamdev added this to the Future Release milestone Dec 23, 2016

@jaswrks jaswrks self-assigned this Apr 17, 2017

jaswrks pushed a commit that referenced this issue Apr 18, 2017

jaswrks
- (s2Member/s2Member Pro) **UI Fix:** All menu page notices should be…
… given the `notice` class and the additional `notice-[type]` class instead of the older generic `updated` and `error` classes. Fixed in this release. Related to [Issue #1034](#1034)

- (s2Member/s2Member Pro) **UI Fix:** Plugins displaying Dashboard-wide notices using the older `updated` and `error` classes should be handled better to avoid displaying them below the s2Member header (on s2Member menu pages) and with non-default WordPress styles. See: [Issue #1034](#1034)

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Apr 18, 2017

jaswrks
- (s2Member/s2Member Pro) **UI Fix:** All menu page notices should be…
… given the `notice` class and the additional `notice-[type]` class instead of the older generic `updated` and `error` classes. Fixed in this release. Related to [Issue #1034](websharks/s2member#1034)

- (s2Member/s2Member Pro) **UI Fix:** Plugins displaying Dashboard-wide notices using the older `updated` and `error` classes should be handled better to avoid displaying them below the s2Member header (on s2Member menu pages) and with non-default WordPress styles. See: [Issue #1034](websharks/s2member#1034)
@raamdev

This comment has been minimized.

Contributor

raamdev commented May 24, 2017

s2Member v170524 has been released and includes changes from this GitHub Issue. See the v170524 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1034).

@raamdev raamdev closed this May 24, 2017

@websharks websharks locked and limited conversation to collaborators May 24, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.