New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-cfasync="false" for Improved CloudFlare Compat. #1038

Closed
jaswrks opened this Issue Jan 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jaswrks
Member

jaswrks commented Jan 10, 2017

See this article at CloudFlare. s2Member scripts should be excluded using this technique; i.e., it would be nice if s2Member could add this attribute so that other portions of the site can still take advantage of Rocket Loader.

@garycarlyle

This comment has been minimized.

garycarlyle commented Jan 12, 2017

Thanks for adding my suggestion as an issue. Sorry I commented with it on another issue. I am quite new to doing this on Github.

jaswrks pushed a commit that referenced this issue Jan 24, 2017

jaswsinc

jaswrks pushed a commit that referenced this issue Jan 24, 2017

jaswsinc
(s2Member/s2Member Pro) **CloudFlare Compat.:** Enhancing compatibili…
…ty with Rocket Loader via `data-cfasync="false"` on dynamic s2Member scripts. See: [Issue #1038](#1038).

@jaswrks jaswrks added this to the Next Release milestone Jan 24, 2017

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 3, 2017

@renzms I'm confirming this issue as tested for s2Member v170126-RC by verifying the data-cfasync="false" attribute has been added to the s2Member JS script inclusion line when viewing the source of my test site running s2Member v170126-RC:

<script type='text/javascript' data-cfasync="false" src='http://local.wordpress.dev/wp-content/plugins/s2member/s2member-o.php?ws_plugin__s2member_js_w_globals=1&#038;qcABC=1&#038;ver=170126-RC-170126-RC-4229804393'></script>
@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 21, 2017

s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1038).

@raamdev raamdev closed this Feb 21, 2017

@websharks websharks locked and limited conversation to collaborators Feb 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.