New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Recurring Subscription Being Downgraded Following Free Trial (PayPal) #1077

Closed
patdumond opened this Issue Apr 14, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@patdumond

patdumond commented Apr 14, 2017

Please see this thread on the WP Sharks forums: https://forums.wpsharks.com/t/free-trial-getting-downgraded/1744/14

This user is having problems with s2Member demoting users following a free trial. The gateway-core-ipn.log indicates that s2Member canceled because the Member canceled at PayPal.

 [0] => IPN received on: Fri Apr 7, 2017 4:45:46 pm UTC
            [1] => s2Member POST vars verified with a Proxy Key
            [2] => s2Member originating domain (`$_SERVER["HTTP_HOST"]`) validated.
            [3] => s2Member `txn_type` identified as ( `subscr_cancel|recurring_payment_profile_cancel|mp_cancel` ).
            [4] => Auto-EOT Time for this account: Fri Apr 7, 2017 4:22 pm UTC
            [5] => Cancellation Notification Emails have been processed.

The site owner says this was a test registration on his account and he did not cancel. He says this is happening with everyone who purchases this non-recurring membership with a trial period. They are canceled at the end of the trial period with this entry in the log. PayPal says they are not sending anything to tell s2Member to cancel.

The site owner is convinced this is a bug in s2Member and I'm almost ready to agree with him. Disclaimer: I have only looked at his logs not his site.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 19, 2017

@patdumond Thank you for the heads up on this. I just reviewed the thread and I will reach out and ask the customer for additional details. I'm also posting a follow-up here in the forum: https://forums.wpsharks.com/t/free-trial-getting-downgraded/1744/26?u=jaswrks

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 19, 2017

This is now a confirmed bug. I will push a fix shortly.

@raamdev raamdev added this to the Next Release milestone Apr 20, 2017

jaswrks pushed a commit that referenced this issue Apr 20, 2017

jaswrks

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Apr 20, 2017

jaswrks

jaswrks pushed a commit that referenced this issue Apr 20, 2017

jaswrks

jaswrks added a commit to websharks/s2member-pro that referenced this issue Apr 20, 2017

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 20, 2017

Coming soon ... Next Release Changelog

(s2Member Pro) Bug Fix: Merchants using PayPal Pro (Payflow Edition) to charge a fixed non-recurring fee following an initial 100% free trial period, were seeing their member accounts EOTd after the trial ended, instead of the EOT Time being set to the end of the fixed term period. Props @patdumond, James Hall, and many others for reporting this in the forums and at GitHub. See Issue #1077.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 20, 2017

Short-Term Patch

  • Download this updated file and upload via FTP, allowing it to override your existing copy of: wp-content/plugins/s2member/src/includes/classes/utils-time.inc.php

  • Also download this updated file and upload via FTP, allowing it to override your existing copy of: wp-content/plugins/s2member-pro/src/includes/classes/gateways/paypal/paypal-payflow-poll.inc.php

@jhall3rd

This comment has been minimized.

jhall3rd commented Apr 20, 2017

Thanks for the attention Jason. Patches uploaded and we will have real-world confirmation of success in about a week when new trials expire.

@raamdev

This comment has been minimized.

Contributor

raamdev commented May 24, 2017

s2Member v170524 has been released and includes changes from this GitHub Issue. See the v170524 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1077).

@raamdev raamdev closed this May 24, 2017

@websharks websharks locked and limited conversation to collaborators May 24, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.