Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s2Member-List /] Search Flag; Display Message #161

Closed
jaswrks opened this issue May 21, 2014 · 2 comments
Closed

[s2Member-List /] Search Flag; Display Message #161

jaswrks opened this issue May 21, 2014 · 2 comments

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 21, 2014

@clavaque writes...

If I'm adding the search box, why would I want it disabled?

The enable_list_search flag is there for security; functionality off by default. If you intend to enable search functionality; and since these shortcodes are separate, the list itself needs to enable search functionality for this to work properly.

That said, what we could do is listen for a search request in the list, and if search is not enabled a message could be displayed. I don't see a security issue with this.

@jaswrks jaswrks self-assigned this May 21, 2014
@jaswrks jaswrks added this to the Next Release milestone May 21, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented May 22, 2014

@BruceCaldwell Would you mind working on this sometime?

What we need is a styled noticed in this template file whenever the $s_var is not empty, and when the shortcode attribute enable_list_search is not on; i.e. somebody tried to search a list that is unsearchable.

We need to display a note to help prevent confusion about this; i.e. to notify the searcher that they just searched an unsearchable list, and if they are the site owner, they should set the enable_list_search attribute before searches are possible.

See also this CSS if you need to add new styles.

@jaswrks
Copy link
Contributor Author

jaswrks commented May 22, 2014

Around line 96 I think. If it goes there you might not need any new CSS, just an altered and/or alternate message for that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant