New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-includes/load.php patch unverifiable. #812

Closed
crazycoolcam opened this Issue Dec 12, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@crazycoolcam

crazycoolcam commented Dec 12, 2015

On updating my WP to 4.4 and s2Member to the latest version, the upgrade said the network patches worked, but using the multisite page to patch the files automatically returned an "unverifiable" error to the load.php patch.

It appears as though WP has changed the details of the line in question to use a function rather than a constant. I believe the line now reads:
if ( empty( $active_plugins ) || wp_installing() )

I manually patched my file to add the preg_match info, but fixing the updater is a good idea. :)

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 12, 2015

@crazycoolcam Thanks for reporting this! I'm giving this a high priority for our next release.

@jaswrks jaswrks added this to the Next Release milestone Dec 12, 2015

@crazycoolcam

This comment has been minimized.

crazycoolcam commented Dec 12, 2015

Sounds good. :)

jaswrks pushed a commit that referenced this issue Dec 18, 2015

@jaswrks jaswrks referenced this issue Dec 18, 2015

Merged

PR: feature/812 #824

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Dec 18, 2015

@jaswrks jaswrks referenced this issue Dec 18, 2015

Merged

PR: feature/812 #112

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 18, 2015

Next Release Changelog:

  • (s2Member/s2Member Pro) WP v4.4 Compat.: This release corrects an issue that impacted sites attempting to run s2Member on a Multisite Network; i.e., it corrects a problem with the load.php patch against the latest release of WordPress. Props @crazycoolcam for reporting! See also this GitHub issue.

@jaswrks jaswrks closed this Dec 18, 2015

@jaswrks jaswrks self-assigned this Dec 18, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 18, 2015

Work from this issue was pushed out with the release of s2Member v151218.
See: http://s2member.com/changelog/ for full details.

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️

@websharks websharks locked and limited conversation to collaborators Dec 18, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 21, 2015

Reopening this issue, as it seems we broke WordPress v4.3 compat. with this update. Working great in WP v4.4 now, but older copies of WordPress receive the wp_installing() call, which does not work on WP v4.3; i.e., that function did not exist in 4.3.

@jaswrks jaswrks reopened this Dec 21, 2015

@websharks websharks unlocked this conversation Dec 21, 2015

@jaswrks jaswrks modified the milestones: Next Release, v151218 Release Dec 21, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 24, 2016

Closing this in favor of: #842 where work is underway to eliminate the need for MS patches altogether.

@jaswrks jaswrks closed this Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment