New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard notice on General Settings page inserts unexpected <em> tags #831

Closed
raamdev opened this Issue Jan 4, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@raamdev
Contributor

raamdev commented Jan 4, 2016

When s2Member is enabled it inserts a Dashboard notice on the General Settings page that explains how s2Member has control over some options on that page. However, that notice appears to be inserting erroneous <em></em> tags that are causing the entire page to become italic.

To reproduce this, install and activate s2Member and then visit Dashboard → General Settings:

2016-01-04_17-23-34

2016-01-04_17-24-20

The italic text is a lot more noticeable when there are other Dashboard notices on the page:

2016-01-04_17-26-35

@raamdev raamdev added the bug label Jan 4, 2016

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jan 6, 2016

Tested and confirming this bug report.

s2Member Bug report: Unexpected <em> tags

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 6, 2016

@raamdev Great catch! Thanks.
@kristineds Thanks for confirming.

@kristineds This would be a good one for you to outline for @renzms to work on, if you don't mind :-).

See this line: https://github.com/websharks/s2member/blob/151218/s2member/includes/classes/op-notices.inc.php#L48

Bug appears to be in this line too: https://github.com/websharks/s2member/blob/151218/s2member/includes/classes/op-notices.inc.php#L81

@raamdev raamdev added this to the Next Release milestone Jan 6, 2016

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jan 7, 2016

@jaswsinc Like this? 😃 cc @renzms


Next Actions

Note: This action will add the missing close <em> tag

  • New feature branch: feature/831 in the websharks/s2member repo.
  • Replace this line with the following:
$notice = "<em>* Note: The s2Member plugin has control over two options on this page.<br /><code>Anyone Can Register = " . esc_html (get_option ("users_can_register")) . "</code>, and <code>New User Default Role = " . esc_html (get_option ("default_role")) . "</code>.<br />For further details, see: <strong>s2Member → General Options → Open Registration</strong>.</em>";
$notice = "<em>* Note: The s2Member plugin has control over two options on this page.<br /><code>Allow Open Registration = " . esc_html (get_site_option ("registration")) . "</code> and <code>Add New Users = " . esc_html (get_site_option ("add_new_users")) . "</code>.<br />Please check: <strong>s2Member → Multisite (Config)</strong>.</em>";
  • Submit PR.
@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 7, 2016

@kristineds Looks great! Nice work :-)

@renzms

This comment has been minimized.

Contributor

renzms commented Jan 8, 2016

@kristineds @jaswsinc

PR submitted, thanks!

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 10, 2016

Next Release Changelog:

  • (s2Member,s2Member Pro) Bug Fix: Resolved a minor glitch in the WordPress Dashboard → Settings → General panel, where s2Member's notice regarding Open Registration was inadvertently forcing the entire page into italics. Props @renzms @kristineds @raamdev ~ See also: this GitHub issue if you'd like additional details.

@jaswrks jaswrks closed this Jan 10, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 10, 2016

@renzms B.e.A.utiful. Thanks everyone! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment