New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2Member missing from wordpress.org #850

Closed
KTS915 opened this Issue Jan 19, 2016 · 15 comments

Comments

Projects
None yet
5 participants
@KTS915

KTS915 commented Jan 19, 2016

s2Member is currently missing from its usual location at https://wordpress.org/plugins/s2member

A visit there is met with the message: "Whoops! We couldn't find that plugin. Maybe you were looking for one of these?"

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 19, 2016

@KTS915 Thank you for the heads up.

I got an email earlier today from a moderator at WordPress.org. It was to notify me that they yanked the plugin due to an infringement that is related to s2Member being run from a Multisite Network and requiring patches in order to integrate full functionality. They don't like this, and they have asked us to remove that portion from the plugin.

We will bend of course, and an update is pending so that it can be brought back online.

@raamdev raamdev added this to the Next Release milestone Jan 19, 2016

jaswrks pushed a commit that referenced this issue Jan 19, 2016

@jaswrks jaswrks referenced this issue Jan 19, 2016

Merged

PR: feature/850 #851

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 19, 2016

jaswrks pushed a commit that referenced this issue Jan 19, 2016

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 19, 2016

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 19, 2016

@ghost

This comment has been minimized.

ghost commented Jan 19, 2016

Note that the .org repository guidelines require all assets be GPL, including images/css/etc.

https://github.com/websharks/s2member-pro/commit/65f36c0acd9f39c5e49695b268cf1cb525f13065#diff-a311bec587883fbe6255678f7e64f5f1R16

https://wordpress.org/plugins/about/guidelines/

"Note: This rule applies to everything in the plugin. This includes code, data, and images, even if you did not create that particular piece. All third-party libraries must also be compatible. For a specific list of compatible licenses, please read the GPL-Compatible license list on gnu.org. Double check your licensing before you start writing your plugin."

Edit: I realize that this is probably just normal docs from the paid code you are porting into the free version, but wanted to give you a heads up.

Edit^2: Or it seems you are moving stuff into -pro which is not the .org version. My bad. Is it possible the plugin team objected just to this language vs the patch itself? Sorry If I'm just confusing things.

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 19, 2016

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 19, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 19, 2016

@strangerstudios writes...

Edit^2: Or it seems you are moving stuff into -pro which is not the .org version. My bad.

No worries. That's right, yes.
We are moving full Multisite Networking support into the pro version for now.

is it possible the plugin team objected just to this language vs the patch itself?

They object to the fact that s2Member requires core patches. I can understand that, as it creates the potential for patches to be lost and things to break, or for other plugins not to work as expected. However, in practice, s2Member has overcome those challenges through automatically patching WP whenever you update it, and by patching it in ways that don't generally raise any conflicts with other plugins. We have had very few problems with this, from a support perspective on our end at least.

However, ideally, we could make s2Member function as intended w/o patching, but a careful review again just now tells me that is still not possible at this time. s2Member allows for a MS network to provide a separate login page for each site, among other things. There currently are no hooks or filters in WP core that allow for this to change at runtime, so a small patch is needed.

This need for us to patch the core is what they object to, and for that reason MS Network functionality has to get moved into the pro version of s2Member for now.

jaswrks pushed a commit that referenced this issue Jan 19, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 19, 2016

Next Release Changelog:

  • (s2Member) Multisite Support: This release of s2Member (the free version only) removes full support for Multisite Networks, which is now a Pro feature; i.e., only available in the Pro version.

    Is s2Member still compatible with WordPress Multisite Networking?

    Multisite support is no longer included in the s2Member Framework. However, it is available with s2Member Pro. s2Member Pro is compatible with Multisite Networking. After you enable Multisite Networking, install the s2Member Pro Add-On. Then, navigate to s2Member → Multisite (Config) in the Dashboard of your Main Site. You can learn more about s2Member Pro at s2Member.com.

    I was using the free version in a Multisite Network before. What happened?

    s2Member (when running on a Multisite Network) requires minor alterations in WordPress core that are not compatible with plugins available at WordPress.org (i.e., not allowed) at this time. For this reason, full support for Multisite Networks is now available only in the pro version.

    What if I already configured Multisite options on a site running the free version?

    If you already customized s2Member's Multisite Network configuration options in a previous release, those settings will remain and still be functional over the short-term; i.e., the functionality that makes s2Member compatible with Multisite Networking is still included, even in the s2Member Framework. However, the routines that deal with core patches, and those that allow you to change Multisite options are no longer available. You will need to acquire the Pro version. Or, you can revert to a previous release. s2Member Framework v151218 is suggested if you go that route.

    See also: this GitHub issue for further details.

@jaswrks jaswrks closed this Jan 19, 2016

@ghost

This comment has been minimized.

ghost commented Jan 20, 2016

Thanks for the details.

@Ipstenu

This comment has been minimized.

Ipstenu commented Jan 20, 2016

The plugin has been restored.

Frankly no plugin who requires editing core files has ever been permitted in the repository, so please report any you see to plugins@wordpress.org and we'll close them until it's fixed. There isn't a 'rule' about it because it's supposed to be self-evident. Don't edit core :)

@KTS915

This comment has been minimized.

KTS915 commented Jan 21, 2016

@KTS915

This comment has been minimized.

KTS915 commented Jan 21, 2016

@Ipstenu: Mika,

You are, by far, my favorite moderator on wordpress. org (even if you did once delete a message of mine!)

But this explanation just won't do. It's not self-evident at all! WP is open source, so anyone is free to do to it what they like.

It might generally be good practice not to edit core, but there are always exceptions and, in any event, best practice is quite different from a qualification for hosting on wordpress.org. (If best practice were the criterion, there would be far fewer plugins on wordpress.org.)

So are there any other such qualifications that are self-evident to you, but which aren't written anywhere, and are you planning to updating the rules soon?

I would happily offer to produce an updated draft, except for the fact that I don't trust one of your fellow mods to follow any rules. He just makes things up as he goes along as it is. I wouldn't want to waste my time. But keep him in check and I'll put my money where my mouth is.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 21, 2016

@KTS915 writes...

@jaswsinc: You might want to respond to this: https://wordpress.org/support/topic/multi-site-support-dropped-but-pro-alternative-misleading?replies=1

Thank you for the heads up. We are asked not to discuss the Pro version over there if we can avoid it, but I did open a new GitHub issue to address some of their questions here: #853

I'll post a reply to that thread in the WordPress forum and try to steer the conversation in this direction.

@Ipstenu

This comment has been minimized.

Ipstenu commented Jan 22, 2016

But this explanation just won't do. It's not self-evident at all! WP is open source, so anyone is free to do to it what they like.

Sure you're free to do what you want. But in our repository, we ask you not tell people to edit source code. It's... If you want to get into a philosophical argument about it, start here - http://websynthesis.com/dont-hack-wordpress-core/ - Andrea speaks for most of us there. Except I don't like the kitten thing...

For developers? Eh, if you edit core, I don't care. You know what you're doing. But it's the same as people who edit plugins or themes. They're going to have a bad time and they are the people who have no business messing with core code. Certainly not on their public sites. That's why we have VVV :)

My point is this: If it's a risk you, who understand the implications, are ready to take? Have fun. Just don't make that call for everyone else. It's not your place.

And it's my place to stop y'all from doing it in the repository :)

ETA: Also please don't badmouth my fellow mods. They're all great people who do their best at a thankless job. They aren't making things up as they go along anymore than the rest of us.

@KTS915

This comment has been minimized.

KTS915 commented Jan 22, 2016

@Ipstenu: Thanks, but let's be clear. I am not a developer. Not of s2Member; nor of anything else.

I am a user and, as with any other website that holds my personal details, I expect it to provide me with clear terms and conditions for usage. You and your fellow mods aren't doing that. Why not?

This isn't a philosophical discussion at all. I want to know what the rules are by which I am supposed to abide and which I can expect others to be held to. I even offered to write them out for others like me.

Yet you refuse to tell me! So much for the idea of a WP community!

@Ipstenu

This comment has been minimized.

Ipstenu commented Jan 22, 2016

If this wasn't clear, I'm only here as the rep for the WP.Org PLUGIN repo, and I'd hoped to clarify why the plugin was removed (tl;dr our system sucks for flagging problems) and that it was restored, and if anyone notices other plugins doing this, please help the community out and let us know. We do appreciate it.

Out of respect for S2 member, this isn't their monkey or circus, so I won't be belaboring this argument in their playground. Sorry about that.

@KTS915 come on by slack and join #forums if you want to talk to the moderators about that. If you have a question about the wordpress.org plugin respository and it's guidelines and violations, email plugins@wordpress.org and you'll probably get me or Otto :)

@KTS915

This comment has been minimized.

KTS915 commented Jan 22, 2016

@Ipstenu: No need to go elsewhere: I think the s2Member devs will indulge us this once.

In any event, my points were clear enough, and the answers should certainly not be private. You are apparently using a set of rules that are not public. Since that's not how an open-source community should work, I'll write them up for you.

Of course, I'll also hold you (and your crazy co-mod) to them. Which is precisely the point.

@Ipstenu

This comment has been minimized.

Ipstenu commented Jan 22, 2016

I have honestly no idea what you're talking about. You've confused me with the forums kvetching.

So are there any other such qualifications that are self-evident to you,

Probably. I'm not actually psychic, rumors to the contrary.

but which aren't written anywhere,

Probably. Most of the ones I handle actually are written down.

and are you planning to updating the rules soon?

Actually we update them regularly.

https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/

Plugin guidelines. Please note that the 'don't edit core' one would fall under our final rule:

We reserve the right to alter this list in the future. We reserve the right to arbitrarily disable or remove any plugin for any reason whatsoever. Basically, this is our repository, and we will attempt to maintain a standard of conduct and code quality. We may not always succeed, but that is our goal, and we will do whatever we feel is necessary in furtherance of that goal.

Not to put too fine a point on it, but enumerating every possible violation and restriction is unmaintanable and just brings out the rules-lawyers in people who like to nitpick, and we try to avoid it.

If you'd like to discuss plugin guidelines, the email is actually a group email and I have a vested interest in people not pinging me directly about issues like this.

The plugin team is a -team- -- a group of people who work on the plugins. While you may only be talking to one 'face' of the team, when you take conversations offline like this, you rob us of the ability to track the status of your plugin. Also you prevent us from being able to use the experience to train up new team members.

I understand you want to have things resolved quickly, and all your questions answered, but this just makes it harder for us to manage everything. Please just use the email like I requested. To do otherwise is disrespectful of S2 member, who I doubt care about this (and didn't argue the change at all), and of the plugin team.

I've made what I thought was a polite request. Ball's in your court.

@websharks websharks locked and limited conversation to collaborators Jan 22, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 22, 2016

@KTS915 @Ipstenu I appreciate you both taking part in a discussion here and please know that you are both welcome to contribute to discussions here in the s2Member repo at GitHub at anytime you like.

However, I'm going to close and lock this issue now, because my feeling is that it would be more constructive for us to put our focus on helping to get some new filters in WP core so that future versions of s2Member will not need to use patches at all. It's going to be way easier once that is done.

Please see: #842

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.