New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-Time-Offer offered everytime, not just first time #855

Closed
jacobposey opened this Issue Jan 21, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@jacobposey

jacobposey commented Jan 21, 2016

I setup a login redirect on the first time login, but everytime I login from work or home, the site sends me to the first time login page. I do not have caching software installed.

Here is an image of the S2 member setup
image

Here is the user login count:

image

@jaswrks jaswrks self-assigned this Jan 24, 2016

jaswrks pushed a commit that referenced this issue Jan 24, 2016

@jaswrks jaswrks referenced this issue Jan 24, 2016

Merged

PR: feature/855 #856

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 24, 2016

@jaswrks jaswrks referenced this issue Jan 24, 2016

Merged

PR: feature/855 #115

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Jan 24, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 24, 2016

Next Release Changelog:

  • (s2Member Pro) One-Time Offer Bug Fix: This release corrects some inconsistencies in the One-Time Offers system that comes with s2Member Pro. Symptoms included seemingly unpredictable behavior whenever redirections were configured without a specific Membership Level. Props @jacobposey for reporting. See also: this GitHub issue if you'd like additional details.

@jaswrks jaswrks closed this Jan 24, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 24, 2016

@jacobposey Thanks for reporting. While I was unable to reproduce the specific bug that you reported whenever I tested in a clean installation of WordPress, I did find some peculiar behavior associated with One-Time Offer URLs that did not include a specific Membership Level. This has been improved.

If you'd like to help us test this, you can swap this updated file with your existing copy of: s2member-pro/includes/classes/login-redirects.inc.php

@jaswrks jaswrks added this to the Next Release milestone Jan 24, 2016

@jacobposey

This comment has been minimized.

jacobposey commented Jan 26, 2016

Thanks for the update. I tried the file and it took my site down - 500 error. So I removed it and will wait for the next release. Thanks for looking into this.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 27, 2016

@jaswsinc Reopening this until you can double-check that the changes to the login-redirects.inc.php did not inadvertently introduce something that might throw a 500 error.

@raamdev raamdev reopened this Jan 27, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 27, 2016

I can confirm that they do not.

@raamdev raamdev closed this Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment