New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Immediate EOT via Payflow API #873

Closed
jaswrks opened this Issue Feb 9, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@jaswrks
Member

jaswrks commented Feb 9, 2016

Under some conditions, the EOT behavior in s2Member Pro will immediately terminate access whenever a customer's subscription naturally expires. Recent versions of the Payflow system set the status to EXPIRED, and this is currently handled as an immediate EOT instead of as a delayed EOT that is subject to date calculations to determine the correct date on which a customer should lose access; i.e., based on what they have already paid for.

Referencing: https://github.com/websharks/s2member-pro/blob/150722/s2member-pro/includes/classes/gateways/paypal/paypal-payflow-poll.inc.php#L90


Next Actions

  • The expired status should be treated as if it were a cancellation instead.

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Feb 9, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Feb 9, 2016

Short-Term Fix

  • Download this updated file.

  • Upload that file, allowing it to override your existing copy of:

    s2member-pro/includes/classes/gateways/paypal/paypal-payflow-poll.inc.php

@jaswrks jaswrks self-assigned this Feb 9, 2016

@jaswrks jaswrks added this to the Next Release milestone Feb 9, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Feb 9, 2016

Next Release Changelog:

  • (s2Member Pro) PayPal Bug Fix: Under some conditions, the EOT behavior in s2Member Pro (when integrated with PayPal Pro) would immediately terminate access whenever a customer's subscription naturally expires. Recent versions of the Payflow system set the status to EXPIRED, and this was handled as an immediate EOT instead of as a delayed EOT that is subject to date calculations to determine the correct date on which a customer should lose access; i.e., based on what they have already paid for. Fixed in this release. See also: this GitHub issue if you'd like additional details.

@jaswrks jaswrks closed this Feb 9, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Feb 17, 2016

A customer confirms this fix resolves the problem for them.
Referencing private/internal ticket: https://websharks.zendesk.com/agent/tickets/10594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment