New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Field on Registration page not shown as Compulsory #907

Closed
spottydog63 opened this Issue Mar 18, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@spottydog63

spottydog63 commented Mar 18, 2016

Looking at the default Registration Fields, the Username, First Name, and Last Name are all compulsory as indicated with the *Asterix next to the Labels.
However, the Email Field does not have an *Asterix.
It is my understanding that it is a Required Field, yet it doesn't appear that way.
screencap

@raamdev

This comment has been minimized.

Contributor

raamdev commented Mar 18, 2016

@spottydog63 Thank you for the bug report.

I have confirmed that this appears to be a bug (tested s2Member v160303):

2016-03-18_13-01-51

It's worth noting also that the default WordPress registration page (with s2Member disabled) does not have any required field indicators:

2016-03-18_13-04-41

@spottydog63

This comment has been minimized.

spottydog63 commented Apr 1, 2016

Hi.
Is there any further info on this?
Regards
Iain

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 8, 2016

Referencing this line in the s2Member codebase that expects the original string to be E-mail (with a dash). However, it now looks like this has changed in a recent version of WordPress, so we should remove the dash to restore the intended translation there in the s2Member source code.

@renzms Is this something you could help with?

@renzms renzms self-assigned this Apr 12, 2016

renzms added a commit that referenced this issue Apr 14, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented Apr 14, 2016

@jaswsinc

PR Submitted, ready for review, thanks!

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 14, 2016

Next Release Changelog:

  • (s2Member/s2Member Pro) Bug Fix: Email field on Registration page not shown as required via * symbol like other fields in this form. Caused by a change in WordPress core. Fixed in this release. Props @spottydog63 @renzms. See also: this GitHub issue for details.

@jaswrks jaswrks closed this Apr 14, 2016

@jaswrks jaswrks added this to the Next Release milestone Apr 14, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 23, 2016

s2Member & s2Member Pro v160423 have been released and they include changes from this GitHub Issue. See the v160423 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)

@websharks websharks locked and limited conversation to collaborators Apr 23, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.