New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP v4.5 Multisite Patches #929

Closed
jaswrks opened this Issue Apr 15, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@jaswrks
Member

jaswrks commented Apr 15, 2016

Multisite patches fail to run when updating and/or reinstalling WordPress whenever v4.5 is the target. The following error output has been reported by others and confirmed by @jaswsinc.

Downloading update from https://downloads.wordpress.org/release/wordpress-4.5-no-content.zip…

Unpacking the update…

Verifying the unpacked files…

Preparing to install the latest version…

Enabling Maintenance mode…

Copying the required files…

Disabling Maintenance mode…

Fatal error: Uncaught Error: Class 'c_ws_plugin__s2member_mms_patches' not found in /wp-business/plugins/s2member-pro/s2member-pro/includes/classes/mms-patches.inc.php:66 Stack trace: #0 /vagrant/src/app/src/wp-includes/plugin.php(235): c_ws_plugin__s2member_pro_mms_patches::sync_mms_patches('Upgrading datab...') #1 /vagrant/src/app/src/wp-admin/includes/update-core.php(1093): apply_filters('update_feedback', 'Upgrading datab...') #2 /vagrant/src/app/src/wp-admin/includes/class-wp-upgrader.php(2352): update_core('/vagrant/src/ap...', '/vagrant/src/ap...') #3 /vagrant/src/app/src/wp-admin/update-core.php(490): Core_Upgrader->upgrade(Object(stdClass), Array) #4 /vagrant/src/app/src/wp-admin/update-core.php(643): do_core_upgrade(true) #5 /vagrant/src/app/src/wp-admin/network/update-core.php(16): require('/vagrant/src/ap...') #6 {main} thrown in /wp-business/plugins/s2member-pro/s2member-pro/includes/classes/mms-patches.inc.php on line 66
@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 15, 2016

Referencing internal/private ticket: https://websharks.zendesk.com/agent/filters/39825039

jaswrks pushed a commit that referenced this issue Apr 15, 2016

@jaswrks jaswrks referenced this issue Apr 15, 2016

Merged

PR: feature/929 #930

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Apr 15, 2016

@jaswrks jaswrks referenced this issue Apr 15, 2016

Merged

PR: feature/929 #121

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 15, 2016

Next Release Changelog:

  • (s2Member Pro) Multisite Patches: Fixed a bug (Uncaught Error: Class 'c_ws_plugin__s2member_mms_patches' not found) whenever WordPress was being updated and Multisite Patches were being applied in the pro version of s2Member. See: this GitHub issue for details.

@jaswrks jaswrks added this to the Next Release milestone Apr 15, 2016

@jaswrks jaswrks self-assigned this Apr 15, 2016

@jaswrks jaswrks closed this Apr 15, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 15, 2016

WP v4.5 Multisite Upgrade Procedure (to avoid this problem)

  • Upgrade s2Member and s2Member Pro ​_before_​ updating WordPress core.

  • Then upgrade WordPress core and observe that Multisite Patches are applied properly.

    If you have already upgraded to WP v4.5 and worked past this issue by patching manually, that's fine. You can still upgrade s2Member and s2Member Pro. After the upgrade you may feel free to enable automatic patching again if that's desirable.

At this time, we have only an early RC available that corrects this. Once beta testing is complete, I will post another update here and of course everyone will be notified about the latest release inside their WP Dashboard.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 23, 2016

s2Member & s2Member Pro v160423 have been released and they include changes from this GitHub Issue. See the v160423 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)

@websharks websharks locked and limited conversation to collaborators Apr 23, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.