New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Array Data Type for `s2member_paid_registration_times` #989

Closed
jaswrks opened this Issue Sep 15, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@jaswrks
Member

jaswrks commented Sep 15, 2016

This line should be changed to:

$paid_registration_times = ($user) ? (array) get_user_option('s2member_paid_registration_times', $user->ID) : array();

@jaswrks jaswrks added the bug label Sep 15, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 15, 2016

i.e., to force an array in case of mild database corruption.

jaswrks pushed a commit that referenced this issue Sep 15, 2016

jaswsinc

jaswrks pushed a commit that referenced this issue Sep 15, 2016

jaswsinc
Merge pull request #990 from websharks/feature/989
Enforce data types for constants. See: #989
@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 15, 2016

Next Release Changelog:

  • Enforce data types when determining PHP constants. See this GitHub issue if you'd like further details.

@jaswrks jaswrks closed this Sep 15, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 15, 2016

Short-Term Fix

Download this updated file and then upload it via FTP, to your site, allowing it to replace your existing copy of s2member/includes/classes/constants.inc.php

@xxxreganxxx

This comment has been minimized.

xxxreganxxx commented Sep 21, 2016

You guys are awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment