Fix buggy auto-purge comment routines #237
Conversation
- Removed `edit_comment` and `delete_comment` action hooks from `auto_purge_comment_post_cache()`; these are now handled by the new `transition_comment_status` hook that is attached to the new `auto_purge_comment_transition()` routine. - Added a new `auto_purge_comment_transition()` routine; this new routine properly handles the transition from one comment status to another and only calls the purge routine when necessary. - A new `static::$static['allow_purging']` variable tracks when a comment status change should _not_ trigger a clear of the post cache and ensures that a subsequent call to `auto_purge_post_cache()` does not cause the post cache to be cleared. This is necessary because, for example, a spam comment will eventually trigger the `clear_post_cache` hook, which attaches directly to `auto_purge_post_cache()` and would result in the post cache being cleared even when the comment cache does not get cleared. See #159
|
Awesome! I am reviewing this and running some quick tests. There was one thing that troubled me, but it seems I overlooked that you are resetting the |
|
Just ran several tests against this where a comment transitions from one status to another. Seems to be working phantasmagorically 👏 From your flowchart to completion, this was awesome work man! Regarding the |
Thanks! This was a PITA to get right.
Done. Thanks! |
|
@raamdev writes... (regarding the latest RC release)
I was unable to reproduce this on a standard WP install (3.9.1), running the latest Quick Cache Pro v140714 (RC). Marking an unapproved comment as Spam did not trigger a clearing of the cache. |
|
@jaswsinc Thanks for testing and for the confirmation! :) |
edit_commentanddelete_commentaction hooks fromauto_purge_comment_post_cache(); these are now handled by the newtransition_comment_statushook that is attached to the newauto_purge_comment_transition()routine.auto_purge_comment_transition()routine; this newroutine properly handles the transition from one comment status to
another and only calls the purge routine when necessary.
static::$static['allow_purging']variable tracks when acomment status change should not trigger a clear of the post cache
and ensures that a subsequent call to
auto_purge_post_cache()doesnot cause the post cache to be cleared. This is necessary because, for
example, a spam comment will eventually trigger the
clear_post_cachehook, which attaches directly to
auto_purge_post_cache()and wouldresult in the post cache being cleared even when the comment cache
does not get cleared.
See #159
@jaswsinc Code review please, when you get a chance?