Skip to content

Add test for same resource with different depth #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Add test for same resource with different depth #422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a5169
Add test for same resource with different depth
s0ph1e Sep 2, 2020
e56f8f3
Merge branch 'master' into add-test-for-max-depth
s0ph1e Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions test/functional/max-depth/max-depth.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,52 @@ describe('Functional: maxDepth and maxRecursiveDepth ', () => {
});
});

it('should correctly save same resource with different depth and maxRecursiveDepth', () => {
/*
pageA -> pageB
pageA -> pageC
pageB -> pageC
* */
const options = {
urls: [ {url: 'http://example.com/pageA.html', filename: 'pageA.html'} ],
directory: testDirname,
subdirectories: null,
sources: [
{ selector: 'a', attr: 'href' }
],
maxRecursiveDepth: 1
};

const pageA = `<html>
<body>
<a href="/pageB.html"></a>
<a href="/pageC.html"></a>
</body>
</html>`;

const pageB = `<html>
<body>
<a href="/pageC.html"></a>
</body>
</html>`;

nock('http://example.com/').get('/pageA.html').reply(200, pageA, {'Content-Type': 'text/html'});
nock('http://example.com/').get('/pageB.html').reply(200, pageB, {'Content-Type': 'text/html'});
nock('http://example.com/').get('/pageC.html').reply(200, 'pageC', {'Content-Type': 'text/html'});

return scrape(options).then(() => {
fs.existsSync(testDirname + '/pageA.html').should.be.eql(true);
fs.existsSync(testDirname + '/pageB.html').should.be.eql(true);
fs.existsSync(testDirname + '/pageC.html').should.be.eql(true);

const pageASaved = fs.readFileSync(testDirname + '/pageA.html').toString();
pageASaved.should.containEql('<a href="pageB.html"');
pageASaved.should.containEql('<a href="pageC.html"');

const pageBSaved = fs.readFileSync(testDirname + '/pageB.html').toString();
// todo: should we change reference here because pageC was already downloaded?
pageBSaved.should.containEql('<a href="/pageC.html"'); // reference to pageC was not changed here because it > maxRecursiveDepth
});
});

});