Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WebSocketServer#close() emit the 'close' event #1453

Merged
merged 1 commit into from Oct 4, 2018
Merged

Make WebSocketServer#close() emit the 'close' event #1453

merged 1 commit into from Oct 4, 2018

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Oct 3, 2018

As titled. Fixes #1375.

@lpinca lpinca merged commit 2a49c09 into master Oct 4, 2018
5 checks passed
@lpinca lpinca deleted the gh-1375 branch Oct 4, 2018
lpinca added a commit that referenced this issue Oct 4, 2018
@rupamkhaitan
Copy link

@rupamkhaitan rupamkhaitan commented Oct 23, 2018

Dint understand this feature.. was the close event not emitted all this while?

@3rd-Eden
Copy link
Member

@3rd-Eden 3rd-Eden commented Oct 25, 2018

Correct. It was never emited on the server instance, but it was on the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants