Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility to wrap a WebSocket in a Duplex stream #1589

Merged
merged 1 commit into from Jul 8, 2019
Merged

Add utility to wrap a WebSocket in a Duplex stream #1589

merged 1 commit into from Jul 8, 2019

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Jun 16, 2019

I'm not sure if it make sense to add this but reasons for doing it are:

stream.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
stream.js Outdated Show resolved Hide resolved
@lpinca
Copy link
Member Author

@lpinca lpinca commented Jun 17, 2019

@3rd-Eden PTAL.

@lpinca lpinca force-pushed the gh-113 branch from d499d8f to 6854293 Jun 17, 2019
@lpinca lpinca force-pushed the gh-113 branch from 6854293 to 7ff212b Jun 17, 2019
@lpinca lpinca merged commit a49a827 into master Jul 8, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 99.914%
Details
@lpinca lpinca deleted the gh-113 branch Jul 8, 2019
@chainhead
Copy link

@chainhead chainhead commented May 11, 2020

How do we read the stream into ws.send()?

This option keeps hitting the event emitter limit - not sure why.

duplex.on('data', (chunk) => {
  ws.send(chunk.toString())
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants