Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerMessageDeflate#cleanup - properly cleanup on close #1618

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@yosiat
Copy link
Contributor

@yosiat yosiat commented Aug 11, 2019

Solves #1617

@yosiat yosiat force-pushed the yosiat:deflate-memory-leak-fix branch 2 times, most recently from e1b71eb to 60991a2 Aug 11, 2019
@lpinca
lpinca approved these changes Aug 12, 2019
lib/permessage-deflate.js Outdated Show resolved Hide resolved
lib/permessage-deflate.js Outdated Show resolved Hide resolved
lib/permessage-deflate.js Outdated Show resolved Hide resolved
@yosiat yosiat force-pushed the yosiat:deflate-memory-leak-fix branch from 652e220 to 4cf280a Aug 12, 2019
@yosiat
Copy link
Contributor Author

@yosiat yosiat commented Aug 12, 2019

@lpinca applied your suggestions, can we merge it and release a version?
I want to use it in production (probably I'll need to fork engine.io)

@lpinca
Copy link
Member

@lpinca lpinca commented Aug 12, 2019

Yes will do in a bit.

@yosiat
Copy link
Contributor Author

@yosiat yosiat commented Aug 12, 2019

@lpinca thanks for all the help!!

@lpinca lpinca merged commit 3a695e8 into websockets:master Aug 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lpinca
Copy link
Member

@lpinca lpinca commented Aug 12, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants