Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

Merged
merged 3 commits into from Oct 14, 2019
Merged

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

merged 3 commits into from Oct 14, 2019

Conversation

@tadeuszwojcik
Copy link
Contributor

@tadeuszwojcik tadeuszwojcik commented Oct 11, 2019

closes #1640

lib/stream.js Outdated Show resolved Hide resolved
…tions which by default are set to false
lib/stream.js Show resolved Hide resolved
lib/stream.js Show resolved Hide resolved
@lpinca
lpinca approved these changes Oct 14, 2019
@lpinca lpinca merged commit 2b7d84d into websockets:master Oct 14, 2019
2 checks passed
2 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@lpinca
Copy link
Member

@lpinca lpinca commented Oct 14, 2019

Thank you.

@tadeuszwojcik
Copy link
Contributor Author

@tadeuszwojcik tadeuszwojcik commented Oct 14, 2019

Thanks!

@tadeuszwojcik
Copy link
Contributor Author

@tadeuszwojcik tadeuszwojcik commented Oct 17, 2019

Do you have rough idea when those changes will be published to NPM? Currently using version from #master but would like to plan migration to stable v7.x, thanks!

@lpinca
Copy link
Member

@lpinca lpinca commented Oct 19, 2019

ws@7.2.0 was released a few minutes ago.

@tadeuszwojcik
Copy link
Contributor Author

@tadeuszwojcik tadeuszwojcik commented Oct 21, 2019

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants