Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not swallow errors emitted while destroying #1672

Merged
merged 1 commit into from Feb 29, 2020
Merged

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Dec 26, 2019

Handle the breaking change introduced by nodejs/node#29197.

@lpinca lpinca merged commit 3e7f69c into master Feb 29, 2020
4 checks passed
4 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@lpinca lpinca deleted the ensure/error-is-emitted branch Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant