Cleaning up server event listeners in WebSocketServer close #253

wants to merge 2 commits into


None yet

2 participants

D1plo1d commented Oct 13, 2013

This was causing subsequent websockets on the same url to fail to upgrade properly for me.

There is still another, unrelated issue related to repeatedly creating and destroying websockets on the same URL. Because this could get confusing quickly I'm going to note in big bold letters here: This Patch Does Not Fix Issue #241.

Running the included patched test against the current eianros:master should fail whereas running it against this branch should succeed.

In the immortal words of Douglas Adams: "Share and Enjoy"

lpinca commented Oct 24, 2016

Closing this as it seems that this change is no longer necessary. Please comment or reopen if needed.

Thank you.

@lpinca lpinca closed this Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment