Prevent shell injection in search. #142
Merged
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2021 17:13
|
The code style changes are embedded by purpose, make things more readable and didn't want to create a PR with those themself only. The changes to fix the shell injection have already have been discussed by mail already and are easy to identify in the first commit. So please don't be too pedantic with "security only" here... :-) |
michael-o
approved these changes
May 11, 2021
k10blogger
approved these changes
May 12, 2021
|
This seem okay merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent shell injection in the search string like reported by cmaloney3030@gmail.com.