Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ArrayBufferView (like Uint8Array) in toBuffer() function #191

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

nazar-pc
Copy link
Contributor

This makes my life a bit simpler when interacting with bittorrent-dht since Uint8Array is supported in browser natively and Buffer is not.

Complements mafintosh/k-rpc#15

https://developer.mozilla.org/en-US/docs/Web/API/ArrayBufferView

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit b5eb707 into webtorrent:master Mar 8, 2018
@feross
Copy link
Member

feross commented Mar 8, 2018

8.2.0

@nazar-pc nazar-pc deleted the patch-1 branch March 8, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants