fix: if websocket closed, don't produce a response

webtorrent · Jul 22, 2021 · ca88435 · ca88435
1 parent 4699cc2
commit ca88435
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/server/swarm.js b/lib/server/swarm.js
@@ -42,6 +42,7 @@ class Swarm {
       self._onAnnounceStarted(params, peer, id)
     } else if (params.event === 'stopped') {
       self._onAnnounceStopped(params, peer, id)
+      if (!cb) return // when websocket is closed
     } else if (params.event === 'completed') {
       self._onAnnounceCompleted(params, peer, id)
     } else if (params.event === 'update') {

diff --git a/server.js b/server.js
@@ -588,7 +588,7 @@ class Server extends EventEmitter {
             event: 'stopped',
             numwant: 0,
             peer_id: socket.peerId
-          }, noop)
+          })
         }
       })
     }

diff --git a/test/request-handler.js b/test/request-handler.js
@@ -14,10 +14,10 @@ function testRequestHandler (t, serverType) {
   class Swarm extends Server.Swarm {
     announce (params, cb) {
       super.announce(params, (err, response) => {
-        if (err) return cb(response)
+        if (cb && err) return cb(response)
         response.complete = 246
         response.extraData = 'hi'
-        cb(null, response)
+        if (cb) cb(null, response)
       })
     }
   }