From 8a235c31e0fe6c44d2ea3005de1cb781b37082fd Mon Sep 17 00:00:00 2001 From: Lucas <5874806+RecoX@users.noreply.github.com> Date: Tue, 1 Oct 2019 11:05:53 +1300 Subject: [PATCH 1/2] mono is needed to create setup.exe --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 51557b66a1..8a72136631 100644 --- a/README.md +++ b/README.md @@ -149,6 +149,12 @@ install [XQuartz](http://www.xquartz.org/), then run: brew install wine ``` +Also to generate the .exe setup we need to install [Mono](https://www.mono-project.com/) + +``` +brew install mono +``` + (Requires the [Homebrew](http://brew.sh/) package manager.) #### Mac build notes @@ -164,7 +170,6 @@ If packaging from Mac, install system dependencies with Homebrew by running: ``` npm run install-system-deps ``` - #### Recommended readings to start working in the app Electron (Framework to make native apps for Windows, OSX and Linux in Javascript): From cb699b5fec235c25cfe96005955ea81c057ff8db Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Mon, 30 Sep 2019 21:48:56 -0700 Subject: [PATCH 2/2] readme: clarify windows homebrew instructions --- README.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 8a72136631..78099b837a 100644 --- a/README.md +++ b/README.md @@ -142,17 +142,12 @@ The Windows app can be packaged from **any** platform. Note: Windows code signing only works from **Windows**, for now. Note: To package the Windows app from non-Windows platforms, -[Wine](https://www.winehq.org/) needs to be installed. For example on Mac, first -install [XQuartz](http://www.xquartz.org/), then run: +[Wine](https://www.winehq.org/) and [Mono](https://www.mono-project.com/) need +to be installed. For example on Mac, first install +[XQuartz](http://www.xquartz.org/), then run: ``` -brew install wine -``` - -Also to generate the .exe setup we need to install [Mono](https://www.mono-project.com/) - -``` -brew install mono +brew install wine mono ``` (Requires the [Homebrew](http://brew.sh/) package manager.)