Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use app.setAsDefaultProtocolClient(protocol) API #285

Closed
feross opened this issue Apr 4, 2016 · 1 comment
Closed

Use app.setAsDefaultProtocolClient(protocol) API #285

feross opened this issue Apr 4, 2016 · 1 comment
Assignees
@feross

Comments

@feross
Copy link
Member

feross commented Apr 4, 2016

0.37.4 added this API after I opened an issue. This will let us remove some code!

electron/electron#4857
electron/electron#4896
@feross feross self-assigned this Apr 4, 2016
@dcposch
Copy link
Contributor

dcposch commented Apr 4, 2016

#83

@feross feross closed this as completed in 3920421 Apr 4, 2016
mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this issue May 26, 2016
@feross
OS X: Use app.setAsDefaultProtocolClient
6fcc9c2 
- OS X: Register as default handler for "magnet" on startup

Also:

- Log errors in the renderer process, like the rest of errors in the
main process
- Windows: Less chance of registry write race condition

Fix webtorrent#285
@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@feross feross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross @dcposch