Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X: Add auto-updater, sign app, build .DMG and .ZIP assets #197

Merged
merged 7 commits into from
Mar 22, 2016
Merged

OS X: Add auto-updater, sign app, build .DMG and .ZIP assets #197

merged 7 commits into from
Mar 22, 2016

Conversation

feross
Copy link
Member

@feross feross commented Mar 22, 2016

  • Add auto-updater (uses Squirrel.Mac, which is built in to electron)
  • Sign app with Apple developer certificate, for two reasons:
    • Required for Squirrel.Mac to verify app updates are signed by the same author as the current version.
    • Allows app to run without the user needing to disable OS X Gatekeeper.
  • Signing OS X apps for distribution outside the App Store requires:
    • Xcode
    • Xcode Command Line Tools (xcode-select --install)
    • Membership in the Apple Developer Program
    • I (Feross) will sign every OS X release and ensure that the certificate is safe.
  • Produce a .DMG file, for easy installs by the user (Releasing builds for linux/mac/windows #12)
    • Here's how it looks:
      screen shot 2016-03-21 at 8 28 24 pm
  • Produce a .ZIP file, which is downloaded and used by the auto-updater.

@feross
move crash reporter placeholder
bd7d4b3
@feross
implement barebones auto updater
d369292
@feross
add log.js module for renderer logging
48c356d
@feross
remove app update check interval
6706bc6 
If there’s an update, this would redownload it every 6 hours until the
app is restarted. We could fix it, but let’s just simplify this:

App updates are checked for on app startup only.
@feross
add config.ROOT_PATH
75fd7aa
@feross
config: put APP_NAME into a variable
801a01b
@feross
OS X: Sign apps, build .DMG and .ZIP assets
5ead803
feross added a commit that referenced this pull request Mar 22, 2016
@feross
Merge pull request #197 from feross/autoupdater
fc5dcf7 
OS X: Add auto-updater, sign app, build .DMG and .ZIP assets
@feross feross merged commit fc5dcf7 into master Mar 22, 2016
@feross feross deleted the autoupdater branch March 22, 2016 03:33
@ungoldman
Copy link
Contributor

Looks great!

@feross
Copy link
Member Author

feross commented Mar 22, 2016

For #190

@feross
Copy link
Member Author

feross commented Mar 22, 2016

@ungoldman Thanks!

@feross
Copy link
Member Author

feross commented Mar 22, 2016

The first release is available here: https://github.com/feross/webtorrent-app/releases/tag/v0.0.0

mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this pull request May 26, 2016
@feross
Merge pull request webtorrent#197 from feross/autoupdater
9d47cf1 
OS X: Add auto-updater, sign app, build .DMG and .ZIP assets
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feross @ungoldman