[CLOSED] allow disabling of trackers/dht and add local ut_metadata/handshake test

[feross]

Issue by fisch0920
Friday May 09, 2014 at 11:22 GMT
Originally opened as https://github.com/feross/bittorrent-client/pull/4

---

• fixed an ordering bug when adding a torrent in buffer form
• added trackersEnabled option to Client and Torrent
• enforced DHT enabling/disabling
• the latter two changes make it easier to test the Clients on real torrents in isolation from external peers.
• added an interesting test case to transfer ut_metadata between two local Clients, both with DHT and trackers disabled, which tests the whole handshake stack and ut_metadata without relying on external servers.

---

fisch0920 included the following code: https://github.com/feross/bittorrent-client/pull/4/commits

[feross]

Comment by fisch0920
Friday May 09, 2014 at 11:27 GMT

---

Note that the next test I want to get working that's currently failing is a variation of this one where one isolated Client and one non-isolated Client connect to each other and ensure that both clients receive the entire torrent. We could also do a similar one without relying on any external servers by allowing bittorrent-client.Client.add(torrentId) to also optionally take in a readable stream of the torrent's complete contents.

[feross]

Comment by fisch0920
Sunday May 11, 2014 at 03:32 GMT

---

Just added another commit that fixed a serious bug in storage.js and added more unit tests.

[feross]

Comment by fisch0920
Sunday May 11, 2014 at 05:38 GMT

---

Also fixes #32

[feross]

Comment by feross
Monday May 12, 2014 at 02:48 GMT

---

As usual, this was an awesome PR! 👍 👍 👍

Only feedback I have is that it would be easier to review if you had multiple smaller commits. But that's minor.

Published as 0.0.5!