Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.remove(torrentId, [function callback (err) {}]) not removing temp folder #1000

Open
davidgatti opened this issue Dec 17, 2016 · 3 comments · May be fixed by #1364
Open

client.remove(torrentId, [function callback (err) {}]) not removing temp folder #1000

davidgatti opened this issue Dec 17, 2016 · 3 comments · May be fixed by #1364

Comments

@davidgatti
Copy link

@davidgatti davidgatti commented Dec 17, 2016

The documentation states:

Remove a torrent from the client. Destroy all connections to peers and delete all saved file data. If callback is specified, it will be called when file data is removed.

The issue that I'm having is with the following statement: and delete all saved file data, this seams not to be true. If I check the content of the following folder /tmp/webtorrent after firing this method, the folder of the selected torrent is not being delete.

Is this a bug, feature or I'm doing something wrong? :)

  • WebTorrent version: 0.98.0
  • Node.js version: v6.4.0
  • Browser name/version (if using WebTorrent in the browser): Using NodeJS module.
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Dec 18, 2016

You're right, this is not behaving as documented. The removal of files on the filesystem is unimplemented. In the meantime, I suggest using the rimraf module to delete the entire /tmp/webtorrent folder, or just the /tmp/webtorrent/<infohash> folder for a single torrent.

@davidgatti

This comment has been minimized.

Copy link
Author

@davidgatti davidgatti commented Dec 18, 2016

OK, good to know :) it be nice if in the documentation there as a sentence like the following:

for not to delete the folder related to the torrent, please implement your own way - or somethign like that to give an idea what to expect :)

@austin-rausch

This comment has been minimized.

Copy link

@austin-rausch austin-rausch commented Mar 21, 2017

The wording seems kind of confusing, if this were implemented would this remove both the tmp folder as well as the path if specified? Or just clean up the tmp folder. I'm assuming it is the latter but I just wanted clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.