Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upwebseed download speed not reported #1006
Comments
This comment has been minimized.
This comment has been minimized.
Are you on a 32-bit system, or compiling your NW.js app as a 32-bit app? This issue could be caused by that, and lots of users ran into this exact error in WebTorrent Desktop before we switched to providing both 32-bit and 64-bit installers. See #895 (comment) |
This comment has been minimized.
This comment has been minimized.
We use the total downloaded bytes to determine the download speed, you can see that here: https://github.com/feross/webtorrent/blob/master/lib/torrent.js#L916-L917 No idea why you're seeing the behavior you describe. Maybe it's related to the exception you're getting ("RangeError: Array buffer allocation failed")? |
This comment has been minimized.
This comment has been minimized.
That's still for torrent, not for the client. Torrent is reporting wrong information, client is getting it right
Yes, a 32-bit app. But does it mean a PC with less than 4GB of ram won't be able to use webseeds? |
This comment has been minimized.
This comment has been minimized.
I don't understand how that's possible. Look at the code: https://github.com/feross/webtorrent/blob/master/lib/torrent.js#L916-L918 We add the same |
This comment has been minimized.
This comment has been minimized.
The amount of RAM in the system isn't the issue. Virtual memory backed by disk exists. The issue is that 32-bit apps don't have enough address space to refer to memory beyond 2GB. Normally WebTorrent shouldn't ever allocate that much RAM, but it can sometimes burst above that amount for brief times especially when downloading fast or with many torrents. There's not an easy way to ensure that systems with low memory won't run out. WebTorrent will operate normally until it tries to allocate memory and it suddenly fails. At that point the app will be in an indeterminate state and it's not clear how to recover. You should really offer a 64-bit version of your app, since 95% of users have 64-bit systems these days. See real-world stats in the issue I linked. |
This comment has been minimized.
This comment has been minimized.
|
webseeds on that torrent were maxing out my connection, yes, somewhere near 35-40mbps |
This comment has been minimized.
This comment has been minimized.
|
these real-world stats are faked, like browsers stats. it's not true. For example, major of countries still are using internet under 128Kb and a 32bit tablet or computers. |
This comment has been minimized.
This comment has been minimized.
|
yes but with 128kbps Internet, they don't have a need for webtorrent, and if they do decide to allocate 100% of their brandwidth for downloading torrents, they still won't max out their ram due to an important amount of data flowing through P2P. So I think it doesnt matter. |
This comment has been minimized.
This comment has been minimized.
|
@madovsky Steam is not faking their stats. Please don't make pointless accusations without any proof. http://store.steampowered.com/hwsurvey |
This comment has been minimized.
This comment has been minimized.
|
eeeerrrrrr! I still encounter the speed issue |
This comment has been minimized.
This comment has been minimized.
|
@vankasteelj I can't reproduce the issue. Not sure what I else I can do. If you can locate the bug, let's fix it. Can you add console.logs to your program to see what the values for |
This comment has been minimized.
This comment has been minimized.
|
that's what I did before opening this ticket^^
reproducable on webtorrent-desktop too, with the torrent linked above: open it, it will load the video, but say 0.01kbps or so, while it's actually going several mb per second (through webseeds) |
This comment has been minimized.
This comment has been minimized.
|
@vankasteelj The torrent link 404s for me now. |
This comment has been minimized.
This comment has been minimized.
|
well feross, first of all, you should accept different opinion in a real open source community. |
This comment has been minimized.
This comment has been minimized.
|
I consider the bug as reported, feel free to take it into account or not. |
This comment has been minimized.
This comment has been minimized.
|
@vankasteelj Thanks for reporting. Sorry we couldn't get this figured out. If you find another link to the torrent file that demonstrates the issue, please share. |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Webseed download is considered "unverified", I believe. Because if I make my own downloadSpeed method, based on client.received instead of client.downloaded, I get the actual information. Note that Windows is registering the speed too.
The first issue: Is this a desired behavior? I somewhat doubt it, because qbittorrent, for example, does account that webseed speed. And also: it does download things, yet it isnt registered by the downloadSpeed. Note that this happens in webtorrent-desktop too.
The second issue is more like a real bug, apparently : when I try to load my torrent, it starts downloading, but it does a rangerError loop and make the browser crash. See the error trace:

Note that this doesnt happen in webtorrent-desktop, it does do weird things but doesn't crash. Maybe it's dumping unverified bytes without writing them?
The (copyright-free) torrent I'm using, for reference.