Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about handling magnets #1020

Closed
CraigglesO opened this issue Jan 18, 2017 · 3 comments
Closed

Question about handling magnets #1020

CraigglesO opened this issue Jan 18, 2017 · 3 comments

Comments

@CraigglesO
Copy link

@CraigglesO CraigglesO commented Jan 18, 2017

Do you request torrent metadata from all the peers you initially connect to?

Or do you

  1. Connect to 1 peer,
  2. ask for torrent metadata
    2.5) Failure -> move to next peer, put this peer on hold
  3. Success -> connect to everyone and start asking for data

I could see asking everyone initially until you set a flag to true and then send cancels and move on.
But then I feel like this overcomplicates the process.

@xuset

This comment has been minimized.

Copy link

@xuset xuset commented Jan 19, 2017

It looks like if the client does not have the metadata then it is requested from all peers it connects to until the metadata is received.

If you want to look it over, it's in lib/torrent.js

@CraigglesO

This comment has been minimized.

Copy link
Author

@CraigglesO CraigglesO commented Jan 19, 2017

Thank you so much!

@feross feross closed this Jan 19, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.