Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MitM Attack webRTC in WebTorrent #1048

Closed
Dimitri-btn opened this issue Feb 17, 2017 · 3 comments
Closed

MitM Attack webRTC in WebTorrent #1048

Dimitri-btn opened this issue Feb 17, 2017 · 3 comments

Comments

@Dimitri-btn
Copy link

@Dimitri-btn Dimitri-btn commented Feb 17, 2017

MitM Attack is possible for webRTC, so is it for webTorrent too ?
https://webrtchacks.com/webrtc-and-man-in-the-middle-attacks/
is there any implementation to prevent webTorrent from this risk ?

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Feb 17, 2017

We one use the RTCDataChannel, the only thing that could go wrong that path is getting or sending the incorrect bytes, wasting bandwidth.

The protection is in the trackers, the signaling servers. The community servers are fine. If you choose to run your own private tracker, make sure to setup your own security.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Feb 20, 2017

Also, torrent files contain hashes of all the pieces in the torrent, so it doesn't matter if you're MitM'd. Your client won't accept pieces that fail hash verification. Also, there's no expectation of privacy in the torrent protocol, as you'll literally connect to anyone that a tracker tells you to.

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.