[CLOSED] Clean debug spew and add sub-piece granularity for downloaded

[feross]

Issue by fisch0920
Monday May 12, 2014 at 09:09 GMT
Originally opened as https://github.com/feross/bittorrent-client/pull/10

---

I'm not sure why the two commits from my last larger PR are in here, but the changes here are actually very minimal. I added a quiet option to the client and made the downloaded estimate use sub-piece granularity.

---

fisch0920 included the following code: https://github.com/feross/bittorrent-client/pull/10/commits

[feross]

Comment by fisch0920
Monday May 12, 2014 at 09:14 GMT

---

For reference, these fix #35 and #7

[feross]

Comment by fisch0920
Monday May 12, 2014 at 10:57 GMT

---

Just added another commit which fixes #8

[feross]

Comment by fisch0920
Thursday May 15, 2014 at 06:27 GMT

---

@feross this PR has become way too large; sorry about that. I wasn't planning on having the last 3 more complex commits in here, but I pushed to master without thinking that they'd be added over here from my previous PR. Please let me know how you'd like to proceed.

As for the last 3 commits, they significantly improve bittorrent-client's throughput and robustness by pulling in a heavily modified version of torrent_stream's guts. The async Storage interface and readable stream implementation also sets us up for having a working webtorrent executable that can save the results to the filesystem and/or stream to VLC.

You'll also notice that I added a pass of removing all of my extraneous trailing whitespaces. I really am sorry this PR has become so large.

[feross]

Comment by fisch0920
Thursday May 15, 2014 at 10:48 GMT

---

Note that this PR partially depends on the smaller PRs to bittorrent-tracker, bittorrent-swarm, and ut_metadata.

[feross]

Comment by feross
Sunday May 18, 2014 at 07:17 GMT

---

AWESOME WORK! Merged 👍

Next time, definitely try to do smaller PRs though ;) This took me forever to review. But a lot of that was probably because it's complicated code solving a complicated problem!

[feross]

Comment by fisch0920
Sunday May 18, 2014 at 09:14 GMT

---

Cool; yeah I will definitely aim for smaller PRs in the future.