Every torrent opens 3 new websockets for tracking

[uhthomas]

What version of WebTorrent?
0.98.8

What operating system and Node.js version?
Windows 10 & Mac OSX Sierra

What browser and version? (if using WebTorrent in the browser)
Chrome Version 56.0.2924.87 (64-bit)

What did you expect to happen?
Not opening 3 websockets for tracking per torrent.

What actually happened?
Every torrent you add, 3 websockets are opened for tracking. When adding many torrents at a time this causes browsers to crash. Even adding 3-4 torrents makes it almost unusable. Surely it makes more sense to open 3 trackers and send 300 messages than open 300 trackers and send 300 messages.

[DiegoRBaquero]

@feross Seems the pool broke! This is urgent. Will investigate.

[DiegoRBaquero]

This is the commit that should be reverted: webtorrent/bittorrent-tracker@3f3db7d

Sockets are no longer closed on eviction.

Need to fix that in uwt too.

[feross]

@DiegoRBaquero Right you are! Sorry, this is my bad! PR incoming.

[feross]

Just committed to master without a PR and released bittorrent-tracker@8.5.2 since this is a bad bug.

[feross]

webtorrent/bittorrent-tracker@1dd1cc3

[DiegoRBaquero]

@feross can we get a new webtorrent build?

We should automate builds on modules update (at least modules built specifically for webtorrent such as the tracker(?))

[feross]

@DiegoRBaquero Done. Published as 0.98.10. @DiegoRBaquero I also gave you npm publish rights so that you can help with this process in the future.

You can do a build with npm run build. However, it's easy to forget to do all the steps when publishing a new release, so I recommend setting up terminal aliases for publishing new versions. My aliases are listed here: https://github.com/feross/prezto/blob/master/runcoms/zshrc#L30-L34

You can run patch, minor, or major to do a release of the given type and it will take care of all the steps. Note: If there is a build or the authors file is updated, then it won't proceed all the way to publish. It will stall and wait for you to git commit the changed file. To continue the process, run postversion. Don't re-run patch, minor, or major a second time, or you will increment the version a second time!

Let me know if you have any questions or run into problems.

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.