Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow down when adding multiple torrents #1065

Closed
uhthomas opened this issue Mar 1, 2017 · 2 comments
Closed

Slow down when adding multiple torrents #1065

uhthomas opened this issue Mar 1, 2017 · 2 comments

Comments

@uhthomas
Copy link

@uhthomas uhthomas commented Mar 1, 2017

What version of WebTorrent?
master (0.98.8) and below

What operating system and Node.js version?
Windows 10 & Mac OSX Sierra

What browser and version? (if using WebTorrent in the browser)
Tried with the latest build of Chrome. Canary and Firefox

What did you expect to happen?
Not slow down and crash webpages.

What actually happened?
Pages slow down significantly when adding multiple torrents at a time. Even with a 100ms delay between adding torrents the page becomes unusable. Adding 50~ torrents with a 100ms between addition, this is the CPU profile
image

This behavior can be seen when going to instant.io and adding maybe 10~ torrents.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 8, 2017

Thanks for posting this issue. I plan to do something about the CPU issue when I get some more time. This is a known issue.

Also, btw, it's probably not a good idea to add 50 torrents to the client (if they are all downloading) at the same time, even once we fix this issue. Most torrent clients limit to 5 active at any given time.

@feross feross closed this Mar 8, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.