Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file.renderTo('div#player') fails #1073

Closed
chovy opened this issue Mar 9, 2017 · 4 comments
Closed

file.renderTo('div#player') fails #1073

chovy opened this issue Mar 9, 2017 · 4 comments

Comments

@chovy
Copy link
Contributor

@chovy chovy commented Mar 9, 2017

Calling file.renderTo('div#player') fails when file is an mp4

Uncaught Error: Cannot render ".mp4" inside a "div" element, expected "video"

using file.appendTo('div#player') works but then I get multiple video objects each time I play a file.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 9, 2017

renderTo is intended to be used with a <video> dom node. You can't use it with a <div>.

You can make a <video id="player"> element and then use renderTo with it.

@feross feross closed this Mar 9, 2017
@chovy

This comment has been minimized.

Copy link
Contributor Author

@chovy chovy commented Mar 9, 2017

I tried that too, it seems to show up but nothing is visible.

I think at the very least the docs should have an example. I'll submit a PR.

@chovy

This comment has been minimized.

Copy link
Contributor Author

@chovy chovy commented Mar 9, 2017

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.