Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFiles under 16Kb are not downloaded correctly #1077
Closed
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
Confirmed this is an issue. Found the bug this was introduced in, using |
This comment has been minimized.
This comment has been minimized.
|
Fixed in 0.98.12. Thanks for reporting! |
This comment has been minimized.
This comment has been minimized.
|
That's great! Thank you. |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of WebTorrent?
0.98.10
What browser and version? (if using WebTorrent in the browser)
Google Chrome v56.0.2924.87 (64-bit)
What did you expect to happen?
I seeded several files. The size of every of them didn't exceed 16Kb. After that, I got the magnet URI and tried to download from other window of the same browser. It seems the files was dowloaded but I couldn't get the content of those files.
To double check it, I uploaded the same file to instant.io and the result was the same.
However, If I use a file > 16Kb it works fine in my implementation and instant.io. You can use the following image to check the problem:
What actually happened?
The file was downloaded but I couldn't get the content of the image or text. I tried with the method
appendToand I got an empty box without any content.Investigation
I investigate a bit the error and the
_notifymethod offile-stream.jsis only called once. The method returns on file-stream.js#L53 and never execute thegetmethod in file-stream.js#L60.