Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you call .seed method, the tracker receives a START event with a "left" parameter greater than zero #1105

Closed
zephrax opened this issue Apr 18, 2017 · 2 comments · Fixed by #1701

Comments

@zephrax
Copy link

@zephrax zephrax commented Apr 18, 2017

Version: webtorrent-hybrid 1.0.5
OS: Archlinux
Node: v.6.10.0

What did you expect to happen?
I expect the tracker receives the "left" parameter with 0, because I'm seeding directly a file I have.

What actually happened?
The tracker got a "left" with the actual size of the file.

I'm trying to detect when a user is going to download a file, and I think this is a false positive.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Apr 18, 2017

Another message with a left=0 is sent shortly after.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 21, 2018

This could be addressed by waiting to start peer discovery until after file verification is complete. Though I haven't considered all the implications of doing this.

@stale stale bot added the stale label Jul 20, 2018
@stale stale bot closed this Jul 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
@feross feross reopened this Aug 9, 2019
@stale stale bot removed the stale label Aug 9, 2019
@webtorrent webtorrent deleted a comment from stale bot Aug 11, 2019
@feross feross closed this in #1701 Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.