Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWebSeed memory hog causing crash (chrome) #1120
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
Hey @kocoten1992, How large was the files you were testing with? Sounds similar to the issue #1303. All the best. |
This comment has been minimized.
This comment has been minimized.
|
@SilentBot1 hey The file should larger than 2GB and we will see the effect. On side note: when doing with big file, don't open f12 (or open and must close it periodically), the console log or the network tab will keep the memory from being collect by garbage collection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of WebTorrent?
0.98.18
What operating system and Node.js version?
Ubuntu 17.04, v7.3.0
What browser and version? (if using WebTorrent in the browser)
Chrome 57.0
It crash wasn't because of file too big for memory, I was using idb-chunk-store and chrome-chunk-store
When just webRTC connection, it went well, but when add webseed it causing crash, my speculation is that, when forEach loop https://github.com/webtorrent/webtorrent/blob/master/lib/webconn.js#L111,
During the loop, memory wasn't release until the end, that what cause the hog (sorry if I'm wrong), might be fix if we split it into smaller forEach.
Thought, boss ?