Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSeed memory hog causing crash (chrome) #1120

Closed
kocoten1992 opened this issue May 3, 2017 · 2 comments
Closed

WebSeed memory hog causing crash (chrome) #1120

kocoten1992 opened this issue May 3, 2017 · 2 comments

Comments

@kocoten1992
Copy link
Contributor

@kocoten1992 kocoten1992 commented May 3, 2017

What version of WebTorrent?
0.98.18
What operating system and Node.js version?
Ubuntu 17.04, v7.3.0
What browser and version? (if using WebTorrent in the browser)
Chrome 57.0

It crash wasn't because of file too big for memory, I was using idb-chunk-store and chrome-chunk-store

When just webRTC connection, it went well, but when add webseed it causing crash, my speculation is that, when forEach loop https://github.com/webtorrent/webtorrent/blob/master/lib/webconn.js#L111,

During the loop, memory wasn't release until the end, that what cause the hog (sorry if I'm wrong), might be fix if we split it into smaller forEach.

Thought, boss ?

@kocoten1992 kocoten1992 closed this Feb 5, 2018
@SilentBot1

This comment has been minimized.

Copy link
Member

@SilentBot1 SilentBot1 commented Mar 1, 2018

Hey @kocoten1992,

How large was the files you were testing with?

Sounds similar to the issue #1303.

All the best.

@kocoten1992

This comment has been minimized.

Copy link
Contributor Author

@kocoten1992 kocoten1992 commented Mar 1, 2018

@SilentBot1 hey

The file should larger than 2GB and we will see the effect.

On side note: when doing with big file, don't open f12 (or open and must close it periodically), the console log or the network tab will keep the memory from being collect by garbage collection.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.