Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the muted option to renderTo #1130

Closed
rayvahey opened this issue May 20, 2017 · 3 comments
Closed

Add the muted option to renderTo #1130

rayvahey opened this issue May 20, 2017 · 3 comments

Comments

@rayvahey
Copy link
Contributor

@rayvahey rayvahey commented May 20, 2017

It's already possible to add autoplay to renderTo
E.g. torrent.files[0].renderTo("#output", { autoplay: true })

However in Android this fails to work because muted needs to also be set, see:
https://developers.google.com/web/updates/2016/07/autoplay

Could we add muted as an option to allow autoplay on Android devices?

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented May 23, 2017

Hey @rayvahey . It's surely possible, willing to work on a PR?

@rayvahey

This comment has been minimized.

Copy link
Contributor Author

@rayvahey rayvahey commented May 27, 2017

Thanks, yes I'll take a look at this one

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 24, 2018

I added a muted option in render-media@3.0.0, so this issue can be closed now.

feross/render-media@168af7a

@feross feross closed this Apr 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.