Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing subtitles and audio with video playback at runtime #1144

Closed
KioriSun opened this issue Jun 15, 2017 · 4 comments
Closed

Managing subtitles and audio with video playback at runtime #1144

KioriSun opened this issue Jun 15, 2017 · 4 comments

Comments

@KioriSun
Copy link

@KioriSun KioriSun commented Jun 15, 2017

This is a feature request.

It would be cool if when playing a video you could choose between the many audio channels a video might have(multiple languages), and couple it with the many subtitles it might come with.
The ability to switch at any moment would complete the player in many ways.

For me, enabling VLC makes swapping the audio channels possible and I just load the srt from the downloaded folder, also forward skipping worked better(shift+arrows).

Great work!

@andreapaiola

This comment has been minimized.

Copy link
Contributor

@andreapaiola andreapaiola commented Jun 20, 2017

Well for subtitles the integration is simple...

https://andreapaiola.name/niagara/

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Jun 20, 2017

Is this for WebTorrent Desktop? Or the webtorrent module?

If it's the module, I'd say it's out of its scope.

@KioriSun

This comment has been minimized.

Copy link
Author

@KioriSun KioriSun commented Jul 7, 2017

I was referring to the desktop app at the time.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 25, 2018

This is a limitation of the HTML5 video tag that we use for playback in the WebTorrent app. If things change and we can allow selection, we'll do it.

@feross feross closed this Apr 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.