Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Improve tests #117

Closed
feross opened this issue Sep 21, 2014 · 3 comments
Closed

[CLOSED] Improve tests #117

feross opened this issue Sep 21, 2014 · 3 comments

Comments

@feross
Copy link
Member

@feross feross commented Sep 21, 2014

Issue by feross
Wednesday Jun 04, 2014 at 06:31 GMT
Originally opened as https://github.com/feross/bittorrent-client/issues/21

  • Tests should run offline, similar to how bittorrent-tracker tests now do.
  • Tests should end correctly and return an exit code. They currently hang indefinitely at the end.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Friday Jun 06, 2014 at 03:03 GMT

@jhiesey fixed one source of tests hanging in webtorrent/bittorrent-tracker@48baf2b There's still lots more to fix.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Friday Jun 06, 2014 at 03:53 GMT

Test hang is fixed in https://github.com/feross/bittorrent-client/commit/8e75930a73226cc2b135e7064ee323872cabb3b4
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Friday Jun 06, 2014 at 07:08 GMT

This is fixed now. Tests can now run entirely offline!
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.