Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrent streams over TLS #1190

Closed
dmarkwat opened this issue Sep 18, 2017 · 3 comments
Closed

Torrent streams over TLS #1190

dmarkwat opened this issue Sep 18, 2017 · 3 comments

Comments

@dmarkwat
Copy link

@dmarkwat dmarkwat commented Sep 18, 2017

There's a feature provided under the BitTorrent reference manual for peers to communicate with one another over SSL/TLS for torrents specifying the 'ssl-cert' field in their info metadata. I'm curious if webtorrent offers this ability to communicate over TLS (far as I can tell it does not?), if there is any plan or interest to, or if there's a recommended approach to accomplishing this.

I saw the 'ssl-cert' field was added to create-torrent (issue here) but I don't see any reference within the webtorrent code to support its presence and use. I did a fair bit of digging over the weekend and I made some progress with a hacked-up impl but am blocked in a few places where a TLS handshake would almost certainly be prone to getting bungled - by intervaled events being sent or even the Wire picking up the handshake and mistaking it for a message. Figured now would be a good time to ask if this is even something of interest before I spent more time on it :)

@knoxcard

This comment has been minimized.

Copy link

@knoxcard knoxcard commented Oct 8, 2017

Yes, dont ISP's look at this data, is everything encrypted? Good point.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 26, 2018

I saw the 'ssl-cert' field was added to create-torrent (issue here) but I don't see any reference within the webtorrent code to support its presence and use.

We added support to create torrents with this field, but the WebTorrent engine doesn't support it.

Figured now would be a good time to ask if this is even something of interest before I spent more time on it :)

This is a neat feature, but I'm skeptical that this is useful in practice. You have to have to set up certificate signing for each peer in some out-of-band method. What is the actual use case for this?

@no-response no-response bot closed this May 10, 2018
@no-response

This comment has been minimized.

Copy link

@no-response no-response bot commented May 10, 2018

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please leave a comment or open a new issue if you have the additional information we need so investigate further.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.