Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a torrent doesn't release memory in the browser #1208

Closed
skzap opened this issue Oct 19, 2017 · 4 comments
Closed

Removing a torrent doesn't release memory in the browser #1208

skzap opened this issue Oct 19, 2017 · 4 comments

Comments

@skzap
Copy link

@skzap skzap commented Oct 19, 2017

What version of WebTorrent?
0098

What browser and version?
Chromium 59

What did you expect to happen?
Ability to seed a 500 MB file, remove it, seed another 500MB file, remove it, seed another 500MB file, etc... without the total memory usage growing
What actually happened?
Removing a torrent doesn't release the memory, therefore after a finite amount of steps, the maximum tab memory usage gets reached.

You can open the chrome task manager to check memory usage.(shift + escape)
You can try through https://btorrent.xyz/ where the same behavior happens.

@disarticulate disarticulate mentioned this issue Oct 26, 2017
2 of 3 tasks complete
@DedSec002

This comment has been minimized.

Copy link

@DedSec002 DedSec002 commented Nov 7, 2017

This issue is not just with seeding the file but also been a same problem when other common operations done on chrome... You can use plugins to limit the usage on each request you make

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 30, 2018

@skzap Can you share the code you're using that causes this issue?

@DiegoRBaquero Is there any chance that this could be a BTorrent.xyz bug? I'm pretty sure that we don't have any memory leaks like this in WebTorrent anymore.

Specifically, you can add, remove, add, remove many dozens of time in WebTorrent Desktop without memory usage growing, so I don't think the core library could have this issue.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Apr 30, 2018

Could be, I'd need to check. @skzap does it happen only in btorrent or is it a general thing?

@no-response no-response bot closed this May 10, 2018
@no-response

This comment has been minimized.

Copy link

@no-response no-response bot commented May 10, 2018

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please leave a comment or open a new issue if you have the additional information we need so investigate further.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.