Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable seed for mobile user #1212

Closed
flyingrub opened this issue Oct 25, 2017 · 4 comments
Closed

Disable seed for mobile user #1212

flyingrub opened this issue Oct 25, 2017 · 4 comments
Labels

Comments

@flyingrub
Copy link

@flyingrub flyingrub commented Oct 25, 2017

Hi !

I was looking for a way to disable seed for mobile user for PeerTube : Chocobozzz/PeerTube#95. But I found that we cannot do that with webtorrent #480.
Our use case here is that mobile user often don't have a unlimited data plan and often it cost you a lot of money as soon as you exceed the amount allowed.

@transitive-bullshit

This comment has been minimized.

Copy link
Member

@transitive-bullshit transitive-bullshit commented Nov 24, 2017

This sounds like a reasonable use case, but I definitely understand the original intent to disallow leechers at the library-level which in the long run will help webtorrent-over-webrtc thrive.

Since bittorrent fundamentally relies on a tit-for-tat exchange strategy, what if we instead added the ability to throttle upload / download speeds on a per-client basis? I believe this would mitigate your original issue while also remaining true to the nature of bittorrent.

@Chocobozzz

This comment has been minimized.

Copy link
Contributor

@Chocobozzz Chocobozzz commented Nov 26, 2017

Throttle seems to be difficult to implement.

Maybe the WebTorrent library could handle seeding deactivation when it detects it is in a mobile web browser or on a cellular network (https://developer.mozilla.org/en-US/docs/Web/API/Network_Information_API). With of course an option to enable/disable this behaviour.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented May 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 3, 2018
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 4, 2018

I don't want to hardcode any special behavior on mobile devices. The correct way to solve this is by implementing throttling. #163

@feross feross closed this May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.