Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use lerna and have all the modules under a single repo ? #1217

Closed
askamist opened this issue Oct 30, 2017 · 3 comments
Closed

Why not use lerna and have all the modules under a single repo ? #1217

askamist opened this issue Oct 30, 2017 · 3 comments

Comments

@askamist
Copy link

@askamist askamist commented Oct 30, 2017

I think having all the modules under one repo helps development because these modules are inter-dependent. especially when there are changes that has to made across these modules.

So why not use lerna ?

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Oct 30, 2017

The modules are inter-dependent, but are also independent. Rarely does it happen that an update on one means update on the other.

@askamist

This comment has been minimized.

Copy link
Author

@askamist askamist commented Nov 2, 2017

But When It does one has to create a pull request on the first repo get it merged then create a pull request on the second repo. Don't you think it would discourage contributions ? and I don't think It is so rare.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Nov 2, 2017

Changes to each module need to be submitted apart, however, I see the benefit while releasing at the same time, but again, that rarely happens in webtorrent, we need to keep things simple and avoid too much tooling, it's fatiguing.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.