Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHashing speed and cores #1233
Hashing speed and cores #1233
Comments
This comment has been minimized.
This comment has been minimized.
|
Yes, it would. Hashing pieces and files would be done faster |
This comment has been minimized.
This comment has been minimized.
|
Thanks @DiegoRBaquero, |
This comment has been minimized.
This comment has been minimized.
|
You would need to reimplemented the hashing either with a different library or by using child processes |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Once a time, I actually measured hashing speed and concluded that it wasn't where WebTorrent was spending a majority of it's time. I agree that theoretically this could make things faster, but we'd need to test it before just assuming that it's a win.
That said, if someone wants to try something clever and send a PR here, I'll take a look at it. |

Hi,
it seems to me that webtorrent uses a single cpu core when hashing 1 (or more) file(s)? Am I correct?
If the disk I/O it's not a problem... would using multi cores speeds up this process?